feat(container-runtime): expose versionMarkResolver on IContainerRuntime - #28168

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (445 lines, 15 files), I've queued these reviewers:

• Correctness — logic errors, race conditions, lifecycle issues
• Security — vulnerabilities, secret exposure, injection
• API Compatibility — breaking changes, release tags, type design
• Performance — algorithmic regressions, memory leaks
• Testing — coverage gaps, hollow tests

How this works

• Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

• Tick Start review below to dispatch the review fleet.

• After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

• This comment updates as new commits land; your reviewer selections are preserved.

• Start review

packages/runtime/container-runtime/src/versionMarks/versionMarkResolver.ts:185

Deep Review: The diagnostic reason is set on returned results — historicalOpsUnavailable at :152, awaitingSequence at :259/:272, historyTrimmed at :265/:269 — but it never reaches the "Resolve" telemetry event. The finally block builds { eventName: "Resolve", outcome, path, durationMs, ...(resolvedSequenceNumber === undefined ? {} : { sequenceNumber }) } with no reason. versionMarkResolver.spec.ts:946-958 confirms the gap: a no-reader resolve returns { kind: "pending", reason: "historicalOpsUnavailable" } while the matching telemetry expectation carries only eventName/outcome/path.

Consequence: the runtime never logs why a mark did not resolve — every host must forward the field itself. The value is low-cardinality and PII-free, so add it to the payload under the same "diagnostic-only, unstable, log-only" rule already applied to the returned field, and update the shape assertion in the spec. If the omission is intentional (cardinality/PII), document it as a non-goal instead — and state the supported way for the runtime, not each host, to log the non-resolution cause.

packages/runtime/container-runtime/src/versionMarks/DEV.md:92

Deep Review: This PR adds readonly versionMarkResolver: IVersionMarkResolver to the @legacy @beta @sealed IContainerRuntime and makes the concrete getter public (no @internal), but DEV.md — a file this PR edits — still describes the old state. Lines 92-95 say the getter is @internal and that "A future public API may move this onto container-runtime definitions rather than the concrete runtime class" — that future move is exactly what this PR does. Line 122 ("Get the resolver: ContainerRuntime.versionMarkResolver") names the superseded access point.

Rewrite the "Host exposure" paragraph (lines 92-95) to state the resolver is now exposed on the @legacy @beta IContainerRuntime interface — drop the @internal wording and the "future public API may move this" sentence — and change line 122 to reference IContainerRuntime.versionMarkResolver.

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

$ start-server-and-test "npm run serve -- --host 127.0.0.1 --no-open" http://127.0.0.1:3000 check-links
1: starting server using command "npm run serve -- --host 127.0.0.1 --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-website@0.0.0 serve
> docusaurus serve --host 127.0.0.1 --no-open

[SUCCESS] Serving "build" directory at: http://127.0.0.1:3000/

> fluid-framework-website@0.0.0 check-links
> linkcheck http://127.0.0.1:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  351523 links
    2064 destination URLs
    2323 URLs ignored
       0 warnings
       0 errors

Deep Review

Reviewed commit 6c241d7 on 2026-09-09.

Readiness: 10/10 — READY

Ready for human review. The redundant compatibility re-export file from the prior review is removed; the supported IContainerRuntimeBase.versionMarkResolver access path, compatibility handling, diagnostics, documentation, and focused tests are coherent.

Context for Reviewers

• Adding the required resolver member to sealed IContainerRuntimeBase preserves supported-interface compatibility; only deprecated, non-sealed IContainerRuntimeWithResolveHandle_Deprecated needs the scoped forward-compatibility acknowledgment.
• runtime-definitions owns the resolver protocol beside IContainerRuntimeBase, while container-runtime retains type-only compatibility re-exports through its existing legacy entrypoints.
• reason?: string adds diagnostic-only context to non-resolved results without changing the resolved, pending, and unresolvable behavioral state machine.
• Older loaders without fetchOps still produce a non-terminal pending result, now with reason: "historicalOpsUnavailable" and matching telemetry.
• Relevant API and compatibility history includes PR Type validate runtime definition packages #8313, PR Next: Fix Type Validation #9584, PR (compat) Added supported features and generation across the Loader / Runtime boundary #22877, PR refactor(packages/framework): Update client packages to use @legacy @beta instead of @legacy @alpha #25268, and PR Export StagingMode as legacy/alpha  #25377; domain ownership includes anthony-murphy, Josmithr, jason-ha, agarwal-navin, and Chentong Zhao.

Bundle size comparison

Base commit: 44e6a4cdf12e0f4dd0cc0e2753f22aa521ecd125
Head commit: 6c241d74d69ef52d8775772f34288c5c9e27d387

Notable changes

No bundles changed by ≥ 500 bytes parsed.